Skip to content

Adds File System metrics and its test scenarios#60

Merged
boyamurthy merged 3 commits into
mainfrom
fileSystemMetrics
May 14, 2024
Merged

Adds File System metrics and its test scenarios#60
boyamurthy merged 3 commits into
mainfrom
fileSystemMetrics

Conversation

@delldubey

Copy link
Copy Markdown
Contributor

Adds unit/int test for added metric API

Description

  • Adds FileSystem Metrics
  • Unit and integration tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1082

Checklist:

  • Have you run format,vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained at least 90% code coverage?
  • Backward compatibility is not broken

How Has This Been Tested?

  • Unit Tests
  • Int Tests with driver

Adds unit/int test for added metric API

Signed-off-by: Utkarsh Dubey <Utkarsh.Dubey@Dell.com>
@delldubey delldubey force-pushed the fileSystemMetrics branch from db020a8 to fe94e7a Compare May 9, 2024 13:44
shanmydell
shanmydell previously approved these changes May 9, 2024
@shanmydell

Copy link
Copy Markdown
Contributor

@delldubey : Please fix security and linting errors.

@delldubey delldubey force-pushed the fileSystemMetrics branch 3 times, most recently from eeab9d0 to fe94e7a Compare May 13, 2024 10:12
delldubey added 2 commits May 13, 2024 23:04
Signed-off-by: Utkarsh Dubey <Utkarsh.Dubey@Dell.com>
@delldubey delldubey force-pushed the fileSystemMetrics branch from 2903ab9 to e73efaa Compare May 13, 2024 17:36
@delldubey

Copy link
Copy Markdown
Contributor Author

@delldubey : Please fix security and linting errors.

Fixed.

@boyamurthy boyamurthy merged commit 0b464a1 into main May 14, 2024
@shanmydell shanmydell deleted the fileSystemMetrics branch October 16, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants