Skip to content

Adding copyMode param in ModifySnapshot API#58

Merged
delldubey merged 1 commit into
mainfrom
metroLinkCopyMode
Jan 25, 2024
Merged

Adding copyMode param in ModifySnapshot API#58
delldubey merged 1 commit into
mainfrom
metroLinkCopyMode

Conversation

@delldubey

@delldubey delldubey commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

Description

  • Adding copy mode param as per actions in Modify Snapshot API

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1115

Checklist:

  • Have you run format, vet & lint checks against your submission?
  • Have you made sure that the code compiles?
  • Did you run the unit & integration tests successfully?
  • Have you maintained at least 90% code coverage?
  • Have you commented your code, particularly in hard-to-understand areas
  • Have you done corresponding changes to the documentation
  • Did you run tests in a real Kubernetes cluster?
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Cluster Testing
  • Unit Testing

tssushma
tssushma approved these changes Jan 25, 2024
View reviewed changes

@tssushma tssushma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delldubey delldubey merged commit 10cd081 into main Jan 25, 2024
@shanmydell shanmydell deleted the metroLinkCopyMode branch January 25, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bharadwajrs-dell bharadwajrs-dell Awaiting requested review from bharadwajrs-dell

@boyamurthy boyamurthy Awaiting requested review from boyamurthy

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@nidtara nidtara Awaiting requested review from nidtara

2 more reviewers

@shanmydell shanmydell shanmydell approved these changes

@tssushma tssushma tssushma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delldubey @shanmydell @tssushma