Skip to content

Added secret inheritance for release action#64

Merged
donatwork merged 2 commits into
mainfrom
secrets-inheritance
Jan 28, 2025
Merged

Added secret inheritance for release action#64
donatwork merged 2 commits into
mainfrom
secrets-inheritance

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Description

Added secret inheritance for release action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

@prablr79 prablr79 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prablr79

Copy link
Copy Markdown
Collaborator

@harishp8889 can you check on the Quality before merging it ?

@donatwork donatwork merged commit f255803 into main Jan 28, 2025
@donatwork donatwork deleted the secrets-inheritance branch January 28, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants