Skip to content

Added iscsi session to getSessions#45

Merged
kumarp20 merged 2 commits into
mainfrom
usr/sreekb/powermax-svc-uts
Feb 27, 2025
Merged

Added iscsi session to getSessions#45
kumarp20 merged 2 commits into
mainfrom
usr/sreekb/powermax-svc-uts

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

Description

The list of ISCSI sessions to match what powermax unit tests expect updated.

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
| https://github.com/dell/csm/issues/1707 |

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran Unit tests locally and against csi-powermax to validate the failed test in csi-powermax.

@github-actions

Copy link
Copy Markdown

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/goiscsi 93.82% (+0.14%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/goiscsi/goiscsi_mock.go 95.00% (+0.56%) 100 (+10) 95 (+10) 5 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@adarsh-dell

Copy link
Copy Markdown
Contributor

Any github issues associated with this fix? At least release activities for 1.14 one?

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the checklist and github issue. Rest LGTM.

@kumarp20 kumarp20 merged commit d591593 into main Feb 27, 2025
@kumarp20 kumarp20 deleted the usr/sreekb/powermax-svc-uts branch February 27, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants