Skip to content

Support for discovery using interface#40

Merged
karthikk92 merged 17 commits into
mainfrom
feat-1714-discover-using-interface
Feb 21, 2025
Merged

Support for discovery using interface#40
karthikk92 merged 17 commits into
mainfrom
feat-1714-discover-using-interface

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Description

Add support for discovery using iSCSI interface.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1714

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • The PowerStore driver was successfully installed in both default and iscsi interface environments, with iSCSI discovery working as expected, and Cert-CSI scale testing results passing.

@AkshaySainiDell AkshaySainiDell changed the title [WIP] Feat 1714 discover using interface Support for discovery using interface Feb 7, 2025
Comment thread utils.go Outdated
Comment thread utils.go Outdated
santhoshatdell
santhoshatdell previously approved these changes Feb 10, 2025
santhoshatdell
santhoshatdell previously approved these changes Feb 18, 2025

@santhoshatdell santhoshatdell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing workflow checks.

@karthikk92 karthikk92 merged commit b88995d into main Feb 21, 2025
@karthikk92 karthikk92 deleted the feat-1714-discover-using-interface branch February 21, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants