Skip to content

ci(linters): added golangci-lint#18

Merged
suryagupta4 merged 1 commit into
mainfrom
ci-add-golangci-lint
Sep 25, 2023
Merged

ci(linters): added golangci-lint#18
suryagupta4 merged 1 commit into
mainfrom
ci-add-golangci-lint

Conversation

@shanduur-dell

@shanduur-dell shanduur-dell commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

Description

This PR adds golangci-lint linters aggregator.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

N/A

Special Notes For Your Reviewer:

This was discussed and accepted during meeting on 2023-08-01.

Additional documentation

N/A

Signed-off-by: shanduur-dell <mateusz.urbanek@dell.com>

@AkshaySainiDell AkshaySainiDell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suryagupta4 suryagupta4 merged commit 9ad6f6b into main Sep 25, 2023
@anandrajak1 anandrajak1 deleted the ci-add-golangci-lint branch October 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants