Skip to content

check for empty volume name#77

Merged
panigs7 merged 2 commits into
mainfrom
vol-name-empty-check
Aug 8, 2025
Merged

check for empty volume name#77
panigs7 merged 2 commits into
mainfrom
vol-name-empty-check

Conversation

@panigs7

@panigs7 panigs7 commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added check to return error if volume name is empty when getting mount info of a device

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Previously, if volume name was empty, getMountInfoFromDevice was still returning sda data which was not required.
image

Added check to return error when volume name is empty

@panigs7 panigs7 marked this pull request as ready for review August 8, 2025 10:02
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gofsutil 85.05% (-0.07%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gofsutil/gofsutil_mount_linux.go 75.88% (-0.15%) 340 (+2) 258 (+1) 82 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

shanmydell
shanmydell approved these changes Aug 8, 2025
View reviewed changes

@shanmydell shanmydell left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@panigs7 panigs7 merged commit 511ec63 into main Aug 8, 2025
6 checks passed
@panigs7 panigs7 deleted the vol-name-empty-check branch August 8, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

@samihan-dell samihan-dell Awaiting requested review from samihan-dell

@chaganti-rajitha chaganti-rajitha Awaiting requested review from chaganti-rajitha

@khareRajshree khareRajshree Awaiting requested review from khareRajshree

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

3 more reviewers

@shanmydell shanmydell shanmydell approved these changes

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@panigs7 @shanmydell @rajendraindukuri @niranjan-n1