Skip to content

Casting Bsize to Int64 to work with GoARCH=386#72

Merged
rajkumar-palani merged 1 commit into
mainfrom
usr/go-arch-bsize-update
Apr 24, 2025
Merged

Casting Bsize to Int64 to work with GoARCH=386#72
rajkumar-palani merged 1 commit into
mainfrom
usr/go-arch-bsize-update

Conversation

@rajkumar-palani

@rajkumar-palani rajkumar-palani commented Apr 23, 2025

Copy link
Copy Markdown
Contributor

Description

Build fails with a type mismatch error related to the statfs.Bsize field in the gofsutil package. This issue occurs only when the Go environment is set to target a 32-bit architecture (GOARCH=386), even if the underlying system is 64-bit.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1858

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Run the make command in both GOARCH=386 & GOARCH=amd64 by updating the commit id of gofsutil in karavi resilency and running make command gets executed successfully.
    image

@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gofsutil 85.12% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/gofsutil/gofsutil_fs.go 100.00% (ø) 39 39 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@rajkumar-palani rajkumar-palani changed the title Casting Bsize to Int64 to with GoARCH=386 Casting Bsize to Int64 to work with GoARCH=386 Apr 23, 2025
@rajkumar-palani rajkumar-palani marked this pull request as ready for review April 24, 2025 06:49
@rajkumar-palani rajkumar-palani merged commit 3e01ce4 into main Apr 24, 2025
@rajkumar-palani rajkumar-palani deleted the usr/go-arch-bsize-update branch April 24, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants