Skip to content

Added secret inheritance for release action#61

Merged
harishp8889 merged 5 commits into
mainfrom
secret-inheritance
Apr 2, 2025
Merged

Added secret inheritance for release action#61
harishp8889 merged 5 commits into
mainfrom
secret-inheritance

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Description

Added secret inheritance for release action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

suryagupta4
suryagupta4 previously approved these changes Jan 13, 2025
prablr79
prablr79 previously approved these changes Jan 13, 2025

@prablr79 prablr79 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prablr79

Copy link
Copy Markdown
Contributor

@harishp8889 check on the quality before merging it

@harishp8889

Copy link
Copy Markdown
Contributor Author

@harishp8889 check on the quality before merging it

Unit tests are failing in main @prablr79

@harishp8889 harishp8889 dismissed stale reviews from prablr79 and suryagupta4 via 4a58823 February 5, 2025 12:07
niranjan-n1
niranjan-n1 previously approved these changes Mar 26, 2025
suryagupta4
suryagupta4 previously approved these changes Mar 26, 2025
Comment thread .github/workflows/release.yaml Outdated
@khareRajshree

Copy link
Copy Markdown
Contributor

Hi @harishp8889, please resolve merge conflicts, possibly that will remove the linting issues as well as some changes are addressed in this #65.

@harishp8889 harishp8889 dismissed stale reviews from suryagupta4 and niranjan-n1 via 7a54b2d April 2, 2025 12:47
@harishp8889 harishp8889 merged commit 883e291 into main Apr 2, 2025
@harishp8889 harishp8889 deleted the secret-inheritance branch April 2, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants