Skip to content

Fix mkfs formatting#43

Merged
adarsh-dell merged 1 commit into
mainfrom
fix-mkfs-formatting
Jul 9, 2024
Merged

Fix mkfs formatting#43
adarsh-dell merged 1 commit into
mainfrom
fix-mkfs-formatting

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Jul 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix mkfs formatting.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1364

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Install PowerFlex driver -> create volume using mkfsFormatOption -> mount volume in a pod
  • Test B

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review July 9, 2024 05:54
adarsh-dell
adarsh-dell approved these changes Jul 9, 2024
View reviewed changes

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adarsh-dell adarsh-dell merged commit 9cedba6 into main Jul 9, 2024
@anandrajak1 anandrajak1 deleted the fix-mkfs-formatting branch October 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

3 more reviewers

@bpjain2004 bpjain2004 bpjain2004 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AkshaySainiDell @bpjain2004 @suryagupta4 @adarsh-dell