Skip to content

Update wwnToDevicePath for nvme devices#42

Merged
delldubey merged 1 commit into
mainfrom
feature/nvmeDevicePath
Jun 19, 2024
Merged

Update wwnToDevicePath for nvme devices#42
delldubey merged 1 commit into
mainfrom
feature/nvmeDevicePath

Conversation

@delldubey

@delldubey delldubey commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Updated wwnToDvicePath to find nvme devices.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1308

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Cluster Test
  • Unit Test
  • image

@alikdell

alikdell commented Jun 14, 2024

Copy link
Copy Markdown
Collaborator
  • I have maintained at least 90% code coverage

How are you achieving this without adding new unit test code?

@delldubey delldubey force-pushed the feature/nvmeDevicePath branch from 7f3f8f4 to 7c5e504 Compare June 17, 2024 14:57
@delldubey

delldubey commented Jun 17, 2024

Copy link
Copy Markdown
Contributor Author
  • I have maintained at least 90% code coverage

How are you achieving this without adding new unit test code?

Pushed test file.

AkshaySainiDell
AkshaySainiDell reviewed Jun 18, 2024
View reviewed changes

@AkshaySainiDell AkshaySainiDell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@delldubey delldubey merged commit 450188e into main Jun 19, 2024
@anandrajak1 anandrajak1 deleted the feature/nvmeDevicePath branch October 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@atye atye Awaiting requested review from atye

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov

+2 more reviewers

@boyamurthy boyamurthy boyamurthy approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delldubey @alikdell @boyamurthy @AkshaySainiDell