Skip to content

Fix linting issue#37

Merged
xuluna merged 3 commits into
mainfrom
luna/lint
Dec 18, 2023
Merged

Fix linting issue#37
xuluna merged 3 commits into
mainfrom
luna/lint

Conversation

@xuluna

@xuluna xuluna commented Dec 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix format and linting issues
Update codeowners

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Run golangci/golangci-lint-action@v3
prepare environment
run golangci-lint
  Running [/home/runner/golangci-lint-1.53.3-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  golangci-lint found no issues
  Ran golangci-lint in 7[19](https://github.com/dell/gofsutil/actions/runs/7253102164/job/19758995465?pr=37#step:5:21)9ms

@xuluna xuluna merged commit 1aacd4a into main Dec 18, 2023
@xuluna xuluna deleted the luna/lint branch December 18, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@IsaiasA1 IsaiasA1 Awaiting requested review from IsaiasA1

@aqu-dell aqu-dell Awaiting requested review from aqu-dell

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@cbartoszDell cbartoszDell Awaiting requested review from cbartoszDell

@bogdanNovikovDell bogdanNovikovDell Awaiting requested review from bogdanNovikovDell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@mdutka-dell mdutka-dell Awaiting requested review from mdutka-dell

+1 more reviewer

@PeresKereotubo PeresKereotubo PeresKereotubo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xuluna @shaynafinocchiaro @PeresKereotubo