Description

After various scale testing, it was identified that removing of the socket was not properly occurring. It is a common misconception that Stat returns of opposite if the file exists for the error, but that is not the case. A common practice is to negate the NotExist check for checking a files existence.

Reference:

• https://gist.github.com/mattes/d13e273314c3b3ade33f
• https://www.tutorialspoint.com/how-to-check-if-a-file-exists-in-golang

After reverting this change, upon a CLBO, the controller pods recover as expected.

GitHub Issues

List the GitHub issues impacted by this PR:

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

• Ensure that all tests run.
• Run a scale test that causes the controller pod to crash and ensure that the tests succeed.