Skip to content

Increase Unit Test Coverage#64

Merged
ChristianAtDell merged 1 commit into
mainfrom
pub/ut-intermediate
Feb 17, 2025
Merged

Increase Unit Test Coverage#64
ChristianAtDell merged 1 commit into
mainfrom
pub/ut-intermediate

Conversation

@ChristianAtDell

@ChristianAtDell ChristianAtDell commented Feb 17, 2025

Copy link
Copy Markdown

Description

This PR includes substantial unit test coverage increase across gocsi packages.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

opensuse154:~/git/gocsi # go test -cover -race ./...
?       github.com/dell/gocsi/middleware/serialvolume/types     [no test files]
        github.com/dell/gocsi/mock/provider             coverage: 0.0% of statements
        github.com/dell/gocsi/mock              coverage: 0.0% of statements
        github.com/dell/gocsi/mock/service              coverage: 0.0% of statements
ok      github.com/dell/gocsi   6.100s  coverage: 80.3% of statements
ok      github.com/dell/gocsi/context   1.055s  coverage: 82.1% of statements
ok      github.com/dell/gocsi/csc       1.029s
ok      github.com/dell/gocsi/csc/cmd   1.111s  coverage: 82.2% of statements
ok      github.com/dell/gocsi/middleware/logging        1.075s  coverage: 82.4% of statements
ok      github.com/dell/gocsi/middleware/requestid      1.092s  coverage: 82.8% of statements
ok      github.com/dell/gocsi/middleware/serialvolume   1.080s  coverage: 91.9% of statements
ok      github.com/dell/gocsi/middleware/serialvolume/etcd      9.454s  coverage: 80.3% of statements
ok      github.com/dell/gocsi/middleware/specvalidator  1.084s  coverage: 80.7% of statements
ok      github.com/dell/gocsi/testing   40.879s coverage: [no statements]
ok      github.com/dell/gocsi/utils     1.254s  coverage: 80.4% of statements

See PR #54 for details.

@ChristianAtDell @JacobGros
@atye @daniyaliqbal2024 @alexemc @alikdell @shaynafinocchiaro
Increase Unit Test Coverage (#54)
f9e7c28 
Co-authored-by: JacobGros <jacobgrosner4@gmail.com>
Co-authored-by: Aaron Tye <tyeaaron@gmail.com>
Co-authored-by: daniyaliqbal2024 <daniyaliqbal_2024@depauw.edu>
Co-authored-by: alexemc <32580729+alexemc@users.noreply.github.com>
Co-authored-by: alikdell <52920355+alikdell@users.noreply.github.com>
Co-authored-by: shaynafinocchiaro <shayna_finocchiaro@dell.com>
@ChristianAtDell ChristianAtDell merged commit 886cd0b into main Feb 17, 2025
@ChristianAtDell ChristianAtDell deleted the pub/ut-intermediate branch February 17, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

+1 more reviewer

@donatwork donatwork donatwork approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristianAtDell @donatwork @alikdell