Skip to content

Fixed Unit Test#89

Merged
satyakonduri merged 5 commits into
mainfrom
investigate-uts-failure
Mar 18, 2025
Merged

Fixed Unit Test#89
satyakonduri merged 5 commits into
mainfrom
investigate-uts-failure

Conversation

@samihan-dell

@samihan-dell samihan-dell commented Mar 11, 2025 •
edited by satyakonduri
Loading

Copy link
Copy Markdown
Contributor

Description

Fixed the failing UT

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tests are passing locally as well as git actions
  • Test B

@satyakonduri satyakonduri changed the title Investigating failed unit test Fixed Unit Test Mar 18, 2025
@satyakonduri satyakonduri marked this pull request as ready for review March 18, 2025 11:17
@github-actions

github-actions Bot commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/gobrick 85.08% (+0.07%) 👍
Coverage by file

Changed unit test files

  • github.com/dell/gobrick/fc_test.go
  • github.com/dell/gobrick/nvme_test.go

chaganti-rajitha
chaganti-rajitha approved these changes Mar 18, 2025
View reviewed changes

@chaganti-rajitha chaganti-rajitha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyakonduri satyakonduri merged commit 3c8680a into main Mar 18, 2025
@satyakonduri satyakonduri deleted the investigate-uts-failure branch March 18, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@atye atye Awaiting requested review from atye

@alankar-verma alankar-verma Awaiting requested review from alankar-verma

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

2 more reviewers

@khareRajshree khareRajshree khareRajshree approved these changes

@chaganti-rajitha chaganti-rajitha chaganti-rajitha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samihan-dell @khareRajshree @chaganti-rajitha @satyakonduri