Updated the go and grpc version for podmon#67
Merged
Conversation
niranjan-n1
approved these changes
Oct 16, 2024
Contributor
|
Can you please update the |
chimanjain
approved these changes
Oct 16, 2024
Contributor
Author
For resiliency Podmon, after editing versions we have tested them and raised PR but for other modules, it would be better the respective teams test the changes and update |
karthikk92
approved these changes
Oct 16, 2024
santhoshatdell
left a comment
Contributor
There was a problem hiding this comment.
Hi @chaganti-rajitha: Historically, we have been updating the go mod references across all sub modules in a single PR. These changes will eventually be pulled in by respective modules and be tested.
Could you see if you can update other sub modules as well? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated the go version for podmon
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
| https://github.com/dell/csm/issues/1435 |
Checklist:
How Has This Been Tested?
I have used these code changes and built image for karavi-resiliency repo and performed short-integration test.
Unit-Test code coverage:
Built image and pushed to harbor and ran short-integration-test