Updated PowerMax Documentation#1450
Closed
rishabhatdell wants to merge 2 commits into
Closed
Conversation
8 tasks
adarsh-dell
reviewed
Feb 11, 2025
|
|
||
| The CSI Driver for Dell PowerMax supports NVMeTCP from v2.11.0. To enable NVMe/TCP provisioning, blockProtocol in settings file should be specified as NVMETCP. | ||
|
|
||
| >**NOTE:** <br>If `X_CSI_TRANSPORT_PROTOCOL` is not specified in the powermax-array-config ConfigMap, the driver will detect the available initiators on the host and choose the protocol. Priority is given to NVMe/TCP, followed by FC, then iSCSI. |
Contributor
There was a problem hiding this comment.
Should we specify both i.e. AUTO and the empty value as both cases are handled in our driver code base?
Contributor
Author
There was a problem hiding this comment.
I don't think so, because here
https://github.com/dell/csi-powermax/blob/1c59cc178a2af03fe436bdd9c1ec60159de7be5f/service/service.go#L730
it just accept these values
FIBRE : Returns FC
FC : Returns FC
ISCSI : Returns ISCSI
NVMETCP : Returns NVMETCP
Empty string ("") : Returns an empty string
Invalid value (e.g., AUTO) : Logs an error and returns an empty string
Contributor
There was a problem hiding this comment.
Auto is a valid input or not, please refer this?
Contributor
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Added it to csi-powermax and documentation
Contributor
|
Please add one screenshot of the preview. |
Contributor
Author
suryagupta4
approved these changes
Feb 27, 2025
Contributor
|
Raised another PR #1457 against this as it had too many conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR updates the priority of CSI PowerMax driver when its set to Auto
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: