Skip to content

Fix image tag#292

Merged
EvgenyUglov merged 2 commits into
mainfrom
usr/evgeny/fix-image-tag
Mar 11, 2025
Merged

Fix image tag#292
EvgenyUglov merged 2 commits into
mainfrom
usr/evgeny/fix-image-tag

Conversation

@EvgenyUglov

@EvgenyUglov EvgenyUglov commented Mar 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds using the environment variable used by the Pipeline to set the nightly image tag during the image build

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1794

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Image is built for both podman and docker targets
[root@master-1-JTwV2YdVOuupv csi-unity]# make docker-build
GOOS=linux CGO_ENABLED=0 GOARCH=amd64 go build -ldflags '-extldflags "-static"' -o bin/csi-unity
docker build --pull -t dellemc/csi-unity/csi-unity:nightly --build-arg GOPROXY= --build-arg BASEIMAGE=quay.io/dell/container-storage-modules/csm-base-image:nightly --build-arg GOIMAGE=golang:1.24 .
Successfully tagged localhost/dellemc/csi-unity/csi-unity:nightly


[root@master-1-JTwV2YdVOuupv csi-unity]# make podman-build
go build .
podman build --pull -t dellemc/csi-unity:nightly --build-arg GOIMAGE=golang:1.24 --build-arg BASEIMAGE=quay.io/dell/container-storage-modules/csm-base-image:nightly --build-arg GOPROXY= . --format=docker
Successfully tagged localhost/dellemc/csi-unity:nightly

@EvgenyUglov EvgenyUglov marked this pull request as ready for review March 11, 2025 16:45
@EvgenyUglov EvgenyUglov merged commit fd920e5 into main Mar 11, 2025
@EvgenyUglov EvgenyUglov deleted the usr/evgeny/fix-image-tag branch March 11, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bandak2 bandak2 Awaiting requested review from bandak2

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@falfaroc falfaroc Awaiting requested review from falfaroc falfaroc is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@karthikk92 karthikk92 Awaiting requested review from karthikk92

@panigs7 panigs7 Awaiting requested review from panigs7

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

3 more reviewers

@donatwork donatwork donatwork approved these changes

@anathoodell anathoodell anathoodell approved these changes

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EvgenyUglov @donatwork @anathoodell @ChristianAtDell