Skip to content

Removing ipv6 ips from gethostIP function#282

Merged
rishabhatdell merged 2 commits into
mainfrom
filter_out_ipv6_ips
Mar 10, 2025
Merged

Removing ipv6 ips from gethostIP function#282
rishabhatdell merged 2 commits into
mainfrom
filter_out_ipv6_ips

Conversation

@sakshi-garg1

@sakshi-garg1 sakshi-garg1 commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

To filter out ipv6 IP addresses from gethostIp function

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1736

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested these changes in k8s cluster as we don't support RKE. Enabled ipv6 on my cluster and ran cert-csi suite for csi-unity with the image having changes.
    cert-csi_run.txt
    Cert-csi passes successfully.

@sakshi-garg1 sakshi-garg1 self-assigned this Feb 10, 2025
@sakshi-garg1 sakshi-garg1 changed the title [WIP]: Removing ipv6 ips from gethostIP function Removing ipv6 ips from gethostIP function Feb 21, 2025
@sakshi-garg1 sakshi-garg1 marked this pull request as ready for review February 25, 2025 05:38
@atye

atye commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

Is there an opportunity to write or update a unit test?

@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-unity/service/utils 90.07% (-0.18%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-unity/service/utils/emcutils.go 88.41% (-0.21%) 207 (+5) 183 (+4) 24 (+1) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@rishabhatdell rishabhatdell merged commit 06f4138 into main Mar 10, 2025
@rishabhatdell rishabhatdell deleted the filter_out_ipv6_ips branch March 10, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdawe tdawe tdawe approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bandak2 bandak2 Awaiting requested review from bandak2

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@panigs7 panigs7 Awaiting requested review from panigs7

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

+4 more reviewers

@atye atye atye approved these changes

@francis-nijay francis-nijay francis-nijay approved these changes

@karthikk92 karthikk92 karthikk92 approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sakshi-garg1 sakshi-garg1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sakshi-garg1 @atye @tdawe @francis-nijay @karthikk92 @suryagupta4 @rishabhatdell