Skip to content

Increase UT coverage for csi-unity to 85%#278

Merged
rishabhatdell merged 14 commits into
mainfrom
feat-unit-test
Mar 10, 2025
Merged

Increase UT coverage for csi-unity to 85%#278
rishabhatdell merged 14 commits into
mainfrom
feat-unit-test

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Feb 4, 2025 •
edited by anandrajak1
Loading

Copy link
Copy Markdown
Contributor

Description

Increase UT coverage for csi-unity to 85%

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Sanity scale testing result : cert-csi test scaling --sc unity-nfs
image

Sanity volume io testing result : cert-csi test vio --sc unity-nfs
image

@KshitijaKakde KshitijaKakde force-pushed the feat-unit-test branch 2 times, most recently from 54923bb to f656954 Compare February 28, 2025 09:07
@karthikk92 karthikk92 changed the title [WIP] Unit Testing Overhaul Increase UT coverage for csi-unity to 85% Mar 10, 2025
@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review March 10, 2025 05:14
karthikk92
karthikk92 previously approved these changes Mar 10, 2025
View reviewed changes
karthikk92
karthikk92 previously approved these changes Mar 10, 2025
View reviewed changes
suryagupta4
suryagupta4 previously approved these changes Mar 10, 2025
View reviewed changes
@karthikk92 karthikk92 dismissed stale reviews from suryagupta4 and themself via d93c18d March 10, 2025 07:58
suryagupta4
suryagupta4 previously approved these changes Mar 10, 2025
View reviewed changes
@rishabhatdell rishabhatdell merged commit 6642773 into main Mar 10, 2025
@rishabhatdell rishabhatdell deleted the feat-unit-test branch March 10, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@bandak2 bandak2 Awaiting requested review from bandak2

@Deepak-Ghivari Deepak-Ghivari Awaiting requested review from Deepak-Ghivari

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@panigs7 panigs7 Awaiting requested review from panigs7

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

5 more reviewers

@rajendraindukuri rajendraindukuri rajendraindukuri approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@rishabhatdell rishabhatdell rishabhatdell approved these changes

@karthikk92 karthikk92 karthikk92 left review comments

@WilsonRadadia20 WilsonRadadia20 WilsonRadadia20 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AkshaySainiDell @rajendraindukuri @karthikk92 @suryagupta4 @rishabhatdell @WilsonRadadia20