Enable unit test actions#226
Merged
Merged
Conversation
Contributor
Author
|
Looks like the linter got updated yesterday to 1.60.1 and some new issues are found. An initial look indicates issues with passing non const format parameters to printf related functions. That exceeds the scope of what I had planned to accomplish. |
mbasha-dell
approved these changes
Aug 15, 2024
shaynafinocchiaro
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable the running of unit tests for build in the GItHub actions. Most of the unit tests are not true unit tests as they require to be run via a shell script with an environment file. I ended up renaming the test/unit-test directory to bdd-test and modified the Makefile to have a new target for bdd-test and unit-test.
Since many unit tests are broken, and not in scope for this PR, I setup the actions to only run tests in service/utils. We will have to eventually decide if we want to fix the unit tests so that they can be run as an action. Right now I'm getting 24.6% coverage but it is a lot of work to get to 80-90%. At least we can get started with this PR.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration