Update basicsystem info usage for probe to reduce authentication calls#224
Merged
AkshaySainiDell merged 6 commits intoAug 14, 2024
Merged
Conversation
Contributor
|
Can a unit test be added? |
rajendraindukuri
approved these changes
Aug 14, 2024
Contributor
We’ve made some tweaks to improve how we probe the array. Instead of using Authenticate, we’re now calling BasicSystemInfo which does not require any session. The outcome of the probe remains the same, so our existing unit tests should cover us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CSM Unity was using login API , updating that to use BasicSystemInfo API to reduce the authentication requests to check array liveness probe
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Ran tests for 4 hours with the health monitor enabled and encountered no 401 errors.