Remove targets from publish context#565
Merged
Merged
Conversation
…hub.com/dell/csi-powerstore into fix/remove-targets-from-publish-context
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
kumarkgosa
approved these changes
Sep 15, 2025
anathoodell
approved these changes
Sep 15, 2025
santhoshatdell
approved these changes
Sep 15, 2025
tdawe
approved these changes
Sep 15, 2025
tdawe
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the code and I don't see any issues since we are just moving the publish context from one place to another.
Collaborator
|
Approved |
Contributor
|
Approved. |
AronAtDell
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding all targets to publish context and passing that to NodeStageVolume can cause an issue when array has many targets.
This PR shifts the logic of target discovery to NodeStageVolume itself to fix the issue.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration