[Powerstore+Auth]: Update IP regex to accept localhost as endpoint#555
Merged
riya-kaushal7997 merged 4 commits intoSep 5, 2025
Merged
Conversation
donatwork
approved these changes
Sep 4, 2025
3779c6c to
14fca9a
Compare
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Auth v2 is enabled, PowerStore secrets provide an endpoint as https://localhost:9400.
Previously, the regex only supported IP addresses, which prevented using localhost or domain-based endpoints.
This change updates the regex validation to accept:
This ensures compatibility with Auth v2 configurations and improves flexibility for different endpoint setups.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Install Powerstore Driver (With Authorization v2)
Install Powerstore Driver (Standalone)