Skip to content

Fix Metro Volume Expansion#548

Merged
rishabhatdell merged 8 commits into
mainfrom
metro-expansion
Aug 28, 2025
Merged

Fix Metro Volume Expansion#548
rishabhatdell merged 8 commits into
mainfrom
metro-expansion

Conversation

@rishabhatdell

@rishabhatdell rishabhatdell commented Aug 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Refactored metro session check by introducing GetMetroSessionState. Controller and Node volume expansion now validate metro session state before and after expansion.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/2002

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Expanded Metro Volumes on Ubuntu
  • Expanded Metro Volumes on RHEL
  • Expanded Non-Metro Volumes Successfully

@github-actions

github-actions Bot commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/controller 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/controller/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/controller/controller_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@rishabhatdell rishabhatdell changed the title Metro expansion Fix Metro Volume Expansion Aug 28, 2025
@rishabhatdell rishabhatdell marked this pull request as ready for review August 28, 2025 08:53
@adarsh-dell

adarsh-dell commented Aug 28, 2025

Copy link
Copy Markdown
Contributor
image

I hope you have tested this on ubuntu, where this was failing?
Wanted to check mark these test cases?

@rishabhatdell

rishabhatdell commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author
image I hope you have tested this on ubuntu, where this was failing? Wanted to check mark these test cases?

tested all

@rishabhatdell rishabhatdell merged commit 11a3cfb into main Aug 28, 2025
6 checks passed
@rishabhatdell rishabhatdell deleted the metro-expansion branch August 28, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@WilsonRadadia20 WilsonRadadia20 WilsonRadadia20 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rishabhatdell @adarsh-dell @AkshaySainiDell @WilsonRadadia20