Skip to content

Updated tenant prefix trimming logic#547

Merged
harishp8889 merged 7 commits into
mainfrom
usr/harishp/node-expand
Sep 1, 2025
Merged

Updated tenant prefix trimming logic#547
harishp8889 merged 7 commits into
mainfrom
usr/harishp/node-expand

Conversation

@harishp8889

@harishp8889 harishp8889 commented Aug 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updated tenant prefix trimming logic when the volume is created with the Authorization module.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1947

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested by installing the driver and expanding the volume by mounting it to a pod.
image image image

@harishp8889 harishp8889 self-assigned this Aug 26, 2025
@harishp8889 harishp8889 marked this pull request as ready for review August 28, 2025 11:38
@harishp8889 harishp8889 mentioned this pull request Aug 28, 2025
Merged
3 tasks
@github-actions

github-actions Bot commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@harishp8889 harishp8889 merged commit 1d7c18d into main Sep 1, 2025
6 checks passed
@harishp8889 harishp8889 deleted the usr/harishp/node-expand branch September 1, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harishp8889 harishp8889

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harishp8889 @AkshaySainiDell @suryagupta4