Bugfix: removeVolumePrefixFromName#534
Merged
Merged
Conversation
JacobGros
previously approved these changes
Aug 8, 2025
JacobGros
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Might be a good idea to add a UT for a case where the prefix occurs multiple times in the volume name.
JacobGros
previously approved these changes
Aug 8, 2025
anathoodell
approved these changes
Aug 8, 2025
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
alexemc
approved these changes
Aug 8, 2025
donatwork
approved these changes
Aug 8, 2025
donatwork
left a comment
Contributor
There was a problem hiding this comment.
The comment seems unnecessary but I'll ignore it for now :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#529 introduced a bug with trimming prefixes. This PR handles that with a cleaner prefix-trim, and adds unit tests.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
See unit tests attached. It was also tested with an image built that has passed OCP E2E tests.