Skip to content

Make PowerStore API timeout configurable#532

Merged
bharathsreekanth merged 18 commits into
mainfrom
usr/sreekb/configurable-timeout-array-connectivity
Aug 18, 2025
Merged

Make PowerStore API timeout configurable#532
bharathsreekanth merged 18 commits into
mainfrom
usr/sreekb/configurable-timeout-array-connectivity

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Introduce environment variable controlled option for Powerstore REST API timeout.
(Corresponding changes are made to helm and operator to enable the same).

If the env var is unspecified, or specified incorrectly, the timeout is defaulted to 5s.

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
https://github.com/dell/csm/issues/1961

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Manually tested deploying the driver and observing relevant logs. Update values/samples and confirm the dynamic change.
  • Unit tests
Coverage results:
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/interceptors is 90.1%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/cmd/csi-powerstore is 90.6%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/identifiers/k8sutils is 90.8%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/controller is 90.5%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/node is 90.1%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/array is 96.1%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/tracer is 100.0%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/identifiers is 95.9%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/provider is 100.0%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/service is 94.4%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/identifiers/fs is 91.7%, not lower than 90%
PASS: coverage for package github.com/dell/csi-powerstore/v2/pkg/identity is 100.0%, not lower than 90%

@bharathsreekanth bharathsreekanth changed the title Usr/sreekb/configurable timeout array connectivity Make PowerStore API timeout configurable Aug 8, 2025
falfaroc
falfaroc reviewed Aug 8, 2025
View reviewed changes
Comment thread pkg/identifiers/identifiers.go Outdated
lukeatdell
lukeatdell reviewed Aug 12, 2025
View reviewed changes
Comment thread pkg/identifiers/identifiers.go Outdated
Comment thread pkg/identifiers/identifiers.go Outdated
Comment thread pkg/identifiers/identifiers.go Outdated
@bharathsreekanth bharathsreekanth force-pushed the usr/sreekb/configurable-timeout-array-connectivity branch from 885d74a to 1e4bea8 Compare August 18, 2025 13:17
@bharathsreekanth bharathsreekanth marked this pull request as ready for review August 18, 2025 15:17
@bharathsreekanth bharathsreekanth force-pushed the usr/sreekb/configurable-timeout-array-connectivity branch from 0caa2c4 to 4f9a344 Compare August 18, 2025 15:18
@bharathsreekanth bharathsreekanth force-pushed the usr/sreekb/configurable-timeout-array-connectivity branch from 533cc69 to 9bb98d6 Compare August 18, 2025 15:43
lukeatdell
lukeatdell previously approved these changes Aug 18, 2025
View reviewed changes
Comment thread pkg/array/array.go Outdated
donatwork
donatwork previously approved these changes Aug 18, 2025
View reviewed changes
Comment thread pkg/identifiers/identifiers.go Outdated
Comment thread pkg/identifiers/identifiers.go
@github-actions

github-actions Bot commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/array 0.00% (ø)
github.com/dell/csi-powerstore/pkg/controller 0.00% (ø)
github.com/dell/csi-powerstore/pkg/identifiers 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/array/array.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/controller_node_to_array_connectivity.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/envvars.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/identifiers.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node_connectivity_checker.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/identifiers/identifiers_test.go

@bharathsreekanth bharathsreekanth merged commit 7c4eae3 into main Aug 18, 2025
6 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/configurable-timeout-array-connectivity branch August 18, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@falfaroc falfaroc Awaiting requested review from falfaroc

2 more reviewers

@donatwork donatwork donatwork approved these changes

@lukeatdell lukeatdell lukeatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bharathsreekanth @falfaroc @donatwork @lukeatdell