Skip to content

Updated host add logic with Auth v2#530

Merged
meggm merged 3 commits into
mainfrom
nfs-mount-fix
Aug 8, 2025
Merged

Updated host add logic with Auth v2#530
meggm merged 3 commits into
mainfrom
nfs-mount-fix

Conversation

@meggm

@meggm meggm commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Updated node ID handling logic for Auth module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1947

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested by installing and creating the volume with and without Auth v2
Screenshot 2025-08-07 175717 image

@meggm meggm marked this pull request as ready for review August 7, 2025 12:32
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/helpers 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/helpers/utils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/helpers/utils_test.go

@meggm meggm merged commit 26c35bb into main Aug 8, 2025
6 checks passed
@meggm meggm deleted the nfs-mount-fix branch August 8, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@ashleyvjoy ashleyvjoy ashleyvjoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@meggm @AkshaySainiDell @ashleyvjoy @harishp8889