Skip to content

Added support for authorization v2 module#520

Merged
harishp8889 merged 11 commits into
mainfrom
feature/authorization-v2
Jul 22, 2025
Merged

Added support for authorization v2 module#520
harishp8889 merged 11 commits into
mainfrom
feature/authorization-v2

Conversation

@harishp8889

@harishp8889 harishp8889 commented Jul 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Added support for authorization v2 module

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1947

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested by installing the driver with Auth v2 enabled
image
  • Tested by installing the driver without Auth v2:
image (7)

@harishp8889 harishp8889 self-assigned this Jul 16, 2025
@github-actions

github-actions Bot commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/identifiers/fs 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/identifiers/fs/fs.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/base.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/identifiers/fs/fs_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@harishp8889 harishp8889 marked this pull request as ready for review July 22, 2025 11:11
@harishp8889 harishp8889 merged commit 314398e into main Jul 22, 2025
6 checks passed
@harishp8889 harishp8889 deleted the feature/authorization-v2 branch July 22, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harishp8889 harishp8889

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harishp8889 @AkshaySainiDell @suryagupta4