Skip to content

Make ListVolumes CSI 1.6 Compliant#511

Merged
chimanjain merged 3 commits into
mainfrom
usr/chiman/list-volume
Jul 2, 2025
Merged

Make ListVolumes CSI 1.6 Compliant#511
chimanjain merged 3 commits into
mainfrom
usr/chiman/list-volume

Conversation

@chimanjain

@chimanjain chimanjain commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Make ListVolume CSI 1.6 Compliant

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1896

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran sanity test successfully for ListVolumes.

Screenshot 2025-06-30 115814

  • Successfully built binary and built image

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/cmd/csi-powerstore 0.00% (ø)
github.com/dell/csi-powerstore/mocks 0.00% (ø)
github.com/dell/csi-powerstore/pkg/array 0.00% (ø)
github.com/dell/csi-powerstore/pkg/controller 0.00% (ø)
github.com/dell/csi-powerstore/pkg/identifiers 0.00% (ø)
github.com/dell/csi-powerstore/pkg/identifiers/fs 0.00% (ø)
github.com/dell/csi-powerstore/pkg/identifiers/k8sutils 0.00% (ø)
github.com/dell/csi-powerstore/pkg/identity 0.00% (ø)
github.com/dell/csi-powerstore/pkg/interceptors 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)
github.com/dell/csi-powerstore/pkg/provider 0.00% (ø)
github.com/dell/csi-powerstore/pkg/service 0.00% (ø)
github.com/dell/csi-powerstore/tests/e2e/k8s 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/cmd/csi-powerstore/main.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/Configurator.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/Consumer.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/ControllerInterface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/FcConnector.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/FileInfo.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/FsInterface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/ISCSIConnector.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/Interface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NASCooldownTracker.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NFSv4ACLsInterface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NVMEConnector.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NodeInterface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NodeVolumePublisher.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/NodeVolumeStager.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/UtilInterface.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/VolumeCreator.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/VolumePublisher.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/mocks/VolumeStager.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/array/array.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/base.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/controller_node_to_array_connectivity.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/creator.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/csi_extension_server.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/publisher.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/envvars.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/fs/fs.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/identifiers.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/k8sutils/k8sutils.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/identifiers/logger.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/interceptors/interceptors.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/base.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node_connectivity_checker.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/publisher.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/stager.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/provider/provider.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/service/service.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/tests/e2e/k8s/externalAccess.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/cmd/csi-powerstore/main_test.go
  • github.com/dell/csi-powerstore/pkg/array/array_test.go
  • github.com/dell/csi-powerstore/pkg/controller/controller_test.go
  • github.com/dell/csi-powerstore/pkg/controller/csi_extension_server_test.go
  • github.com/dell/csi-powerstore/pkg/controller/replication_test.go
  • github.com/dell/csi-powerstore/pkg/identifiers/fs/fs_test.go
  • github.com/dell/csi-powerstore/pkg/identifiers/identifiers_test.go
  • github.com/dell/csi-powerstore/pkg/identifiers/k8sutils/k8sutils_test.go
  • github.com/dell/csi-powerstore/pkg/identity/identity_test.go
  • github.com/dell/csi-powerstore/pkg/interceptors/interceptors_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_connectivity_checker_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_test.go
  • github.com/dell/csi-powerstore/pkg/node/stager_test.go
  • github.com/dell/csi-powerstore/pkg/service/service_test.go

@chimanjain

chimanjain commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

Re ran the cert csi test, same result.

@chimanjain chimanjain merged commit 09fbd8a into main Jul 2, 2025
6 checks passed
@chimanjain chimanjain deleted the usr/chiman/list-volume branch July 2, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@niranjan-n1 niranjan-n1 niranjan-n1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chimanjain @AkshaySainiDell @niranjan-n1