PowerStore CSI driver incorrectly labelling nodes for NFS protocol#503
Merged
Conversation
b0d40cc to
aaeea38
Compare
3c762b3 to
53f15ff
Compare
suryagupta4
previously approved these changes
Jun 24, 2025
rishabhatdell
previously approved these changes
Jun 24, 2025
bpjain2004
reviewed
Jun 24, 2025
alexemc
reviewed
Jun 24, 2025
09036cc
bpjain2004
previously approved these changes
Jun 25, 2025
rishabhatdell
previously approved these changes
Jun 25, 2025
adarsh-dell
reviewed
Jun 25, 2025
94448fd
santhoshatdell
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Add the unit test that @AkshaySainiDell mentioned.
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
AkshaySainiDell
approved these changes
Jun 26, 2025
rishabhatdell
approved these changes
Jun 26, 2025
santhoshatdell
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PowerStore CSI driver incorrectly labelling nodes for NFS protocol
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?