Skip to content

PowerStore CSI driver incorrectly labelling nodes for NFS protocol#503

Merged
karthikk92 merged 17 commits into
mainfrom
bugfix-1808-nfs-label
Jun 26, 2025
Merged

PowerStore CSI driver incorrectly labelling nodes for NFS protocol#503
karthikk92 merged 17 commits into
mainfrom
bugfix-1808-nfs-label

Conversation

@karthikk92

@karthikk92 karthikk92 commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

Description

PowerStore CSI driver incorrectly labelling nodes for NFS protocol

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1808

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • Installed Driver with 1 NFS Enabled Array and nfs label applies as expected and able to provision volumes.
  • Installed Driver with 1 NFS Disabled Array and nfs label not applies as expected and able to provision volumes.
  • Installed Driver with Multi-Array (Array1: NFS Disabled & Array2: NFS Enabled):
    • NFS label not added for Array1 to csinode.
    • NFS label added for Array2 to csinode.
    • Provisioning failed for NFS volumes for Array1.
    • Able to provision for NFS volumes for Array2.
  • Upgrade test from 2.14 to latest driver
    • Provisioning failed for NFS volumes.
    • Provisioning worked for non-NFS volumes.
    • Tested against non-NFS volumes created before the upgrade:
      • Validated volume can be re-mounted to the same node as well as a different node.
      • Validated Snapshot:
        • Write data to the volume.
        • Validated that a snapshot can be taken.
        • Validated volume creation from snapshot.
      • Validated that volume cloning is possible.
        • Validated that the cloned volume can be mounted.

@karthikk92 karthikk92 force-pushed the bugfix-1808-nfs-label branch 2 times, most recently from b0d40cc to aaeea38 Compare June 24, 2025 10:34
@karthikk92 karthikk92 force-pushed the bugfix-1808-nfs-label branch from 3c762b3 to 53f15ff Compare June 24, 2025 10:59
@karthikk92 karthikk92 marked this pull request as ready for review June 24, 2025 11:04
suryagupta4
suryagupta4 previously approved these changes Jun 24, 2025
rishabhatdell
rishabhatdell previously approved these changes Jun 24, 2025
Comment thread pkg/node/node.go
Comment thread pkg/node/node_test.go Outdated
@karthikk92 karthikk92 dismissed stale reviews from rishabhatdell and suryagupta4 via 09036cc June 24, 2025 13:22
bpjain2004
bpjain2004 previously approved these changes Jun 25, 2025
rishabhatdell
rishabhatdell previously approved these changes Jun 25, 2025
Comment thread pkg/common/common_test.go Outdated
@karthikk92 karthikk92 dismissed stale reviews from rishabhatdell and bpjain2004 via 94448fd June 25, 2025 10:24
Comment thread pkg/node/node_test.go

@santhoshatdell santhoshatdell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Add the unit test that @AkshaySainiDell mentioned.

@github-actions

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/common 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/common/common.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/common/common_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@karthikk92 karthikk92 merged commit 86aebc6 into main Jun 26, 2025
6 checks passed
@karthikk92 karthikk92 deleted the bugfix-1808-nfs-label branch June 26, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants