Skip to content

Improvements for Shared NFS scalability#485

Merged
lukeatdell merged 22 commits into
mainfrom
usr/lukeatdell/scale1
May 16, 2025
Merged

Improvements for Shared NFS scalability#485
lukeatdell merged 22 commits into
mainfrom
usr/lukeatdell/scale1

Conversation

@lukeatdell

@lukeatdell lukeatdell commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Improvements to scalability:

  • additions to unmount any potential duplicate entries and unmount with 'lazy' option
  • Node Stage and Unstage now call the NFS service implementation of the functions to perform update stage and unstage operations.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1742

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  • OCP e2e: OpenShift CSI extended - SCSI LUN Overflow.
  • Provisioning volumes until reaching the PowerStore array limit.
  • cert-csi certify
    • block
    • metro
    • nfs
    • SharedNFS

xuluna
xuluna reviewed May 15, 2025
View reviewed changes
Comment thread go.mod Outdated
@lukeatdell lukeatdell marked this pull request as ready for review May 15, 2025 17:27
AronAtDell
AronAtDell reviewed May 15, 2025
View reviewed changes
Comment thread go.sum Outdated
xuluna
xuluna reviewed May 15, 2025
View reviewed changes
Comment thread pkg/service/node.go
xuluna
xuluna previously approved these changes May 15, 2025
View reviewed changes
santhoshatdell
santhoshatdell previously approved these changes May 15, 2025
View reviewed changes
@falfaroc falfaroc dismissed stale reviews from santhoshatdell, xuluna, and bharathsreekanth via 660370c May 15, 2025 21:01
xuluna
xuluna previously approved these changes May 16, 2025
View reviewed changes
@github-actions

github-actions Bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/service/node.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/service/service.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/service/node_test.go

@anandrajak1 anandrajak1 requested review from falfaroc and xuluna May 16, 2025 18:03
@lukeatdell lukeatdell merged commit b8c8eb0 into main May 16, 2025
6 checks passed
@lukeatdell lukeatdell deleted the usr/lukeatdell/scale1 branch May 16, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdawe tdawe tdawe approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@donatwork donatwork Awaiting requested review from donatwork

@AronAtDell AronAtDell Awaiting requested review from AronAtDell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@xuluna xuluna Awaiting requested review from xuluna

@falfaroc falfaroc Awaiting requested review from falfaroc

+2 more reviewers

@ChristianAtDell ChristianAtDell ChristianAtDell approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@lukeatdell @tdawe @xuluna @AronAtDell @bharathsreekanth @ChristianAtDell @santhoshatdell @rbo54 @falfaroc