Skip to content

Controller updates to use thread-safe custom HTTP header#481

Merged
bharathsreekanth merged 6 commits into
mainfrom
usr/sreekb/refactor-headers
May 7, 2025
Merged

Controller updates to use thread-safe custom HTTP header#481
bharathsreekanth merged 6 commits into
mainfrom
usr/sreekb/refactor-headers

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented May 6, 2025

Copy link
Copy Markdown
Contributor

Description

Use thread safe way to handle custom HTTP headers from gopowerstore.

GitHub Issues

GitHub Issue #
https://github.com/dell/csm/issues/1742

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

  1. Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
    Unit tests
ok      github.com/dell/csi-powerstore/v2/pkg/array     1.268s  coverage: 93.2% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common    3.339s  coverage: 96.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common/fs 1.324s  coverage: 90.6% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/common/k8sutils   2.658s  coverage: 90.8% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/controller        2.707s  coverage: 90.7% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/identity  1.187s  coverage: 100.0% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/interceptors      4.018s  coverage: 90.1% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/node      4.282s  coverage: 90.2% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/provider  1.257s  coverage: 100.0% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/service   1.304s  coverage: 95.3% of statements
ok      github.com/dell/csi-powerstore/v2/pkg/tracer    1.202s  coverage: 100.0% of statements
  1. Ran shared NFS and iSCSI provisioning of volumes to the order of about 400 volumes, using cert-csi (test scaling). Verified there are no controller pod crashes. In the past, about 100+ would often panic the controller pod.
  2. Ran provisioning on OCP and K8S clusters.

lukeatdell
lukeatdell previously approved these changes May 7, 2025
falfaroc
falfaroc previously approved these changes May 7, 2025
Comment thread go.sum Outdated
@bharathsreekanth bharathsreekanth dismissed stale reviews from falfaroc and lukeatdell via 0dc1db8 May 7, 2025 18:09
@github-actions

github-actions Bot commented May 7, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/controller 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/controller/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/controller/creator.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/controller/controller_test.go
  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@bharathsreekanth bharathsreekanth merged commit 22bac47 into main May 7, 2025
6 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/refactor-headers branch May 7, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants