Skip to content

Update storage class parameter from csi-nfs to shared-nfs#479

Merged
tdawe merged 2 commits into
mainfrom
usr/tdawe/rename-csi-nfs-shared-nfs
May 2, 2025
Merged

Update storage class parameter from csi-nfs to shared-nfs#479
tdawe merged 2 commits into
mainfrom
usr/tdawe/rename-csi-nfs-shared-nfs

Conversation

@tdawe

@tdawe tdawe commented May 2, 2025

Copy link
Copy Markdown
Contributor

Description

Update storage class parameter from csi-nfs to shared-nfs.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1742

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Deployed driver with recent shared-nfs changes and verified new StorageClass parameter is used and functionality remains the same.

falfaroc
falfaroc previously approved these changes May 2, 2025
View reviewed changes
santhoshatdell
santhoshatdell previously approved these changes May 2, 2025
View reviewed changes
@tdawe tdawe dismissed stale reviews from bharathsreekanth, santhoshatdell, and falfaroc via ebeae5c May 2, 2025 18:00
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/controller 0.00% (ø)
github.com/dell/csi-powerstore/pkg/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/controller/replication.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/service/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@tdawe tdawe merged commit 9df938c into main May 2, 2025
6 checks passed
@tdawe tdawe deleted the usr/tdawe/rename-csi-nfs-shared-nfs branch May 2, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@AkshaySainiDell AkshaySainiDell Awaiting requested review from AkshaySainiDell

@donatwork donatwork Awaiting requested review from donatwork

3 more reviewers

@falfaroc falfaroc falfaroc approved these changes

@santhoshatdell santhoshatdell santhoshatdell approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tdawe @falfaroc @bharathsreekanth @santhoshatdell