Skip to content

Host Registration for Powerstore Metro#470

Merged
meggm merged 60 commits into
mainfrom
usr/meggm/metro_host
May 6, 2025
Merged

Host Registration for Powerstore Metro#470
meggm merged 60 commits into
mainfrom
usr/meggm/metro_host

Conversation

@mgandharva

@mgandharva mgandharva commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Description

As a Kubernetes admin, I need the PowerStore CSI driver to distinguish between local and remote hosts during driver startup. Currently, all hosts are registered as local, which is not suitable for Uniform Metro configurations where hosts connect to all storage arrays. This new feature will support explicit host registration to define which hosts are local and which are remote.
During the CSI driver startup, support registering the host as:

  • Local
  • Co-located with both systems
  • Co-located with Remote System
  • Co-located with Local System

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1753

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested with two node cluster (one master and one worker)
    image

  • Tested with three node cluster (one master and two worker)
    image

@mgandharva mgandharva marked this pull request as ready for review April 28, 2025 10:52
Comment thread pkg/node/node.go
Comment thread pkg/node/node.go
@adarsh-dell

Copy link
Copy Markdown
Contributor

I can see 2 more fields being introduced to array struct MetroTopology Labels . I believe we need to update the same in the sample here, what do you think?

Comment thread pkg/array/array.go
Comment thread pkg/node/node.go
Comment thread pkg/node/node.go Outdated
Comment thread pkg/node/node.go Outdated
Comment thread samples/secret/secret.yaml Outdated
Comment thread pkg/node/node.go Outdated
Comment thread pkg/node/node.go Outdated
Signed-off-by: meghana_gm <meghana.gm@dell.com>
@meggm meggm requested a review from adarsh-dell May 5, 2025 12:27
@github-actions

github-actions Bot commented May 5, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/pkg/array 0.00% (ø)
github.com/dell/csi-powerstore/pkg/node 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/pkg/array/array.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerstore/pkg/node/node.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/node/node_test.go

@ashleyvjoy

Copy link
Copy Markdown

I can see 2 more fields being introduced to array struct MetroTopology Labels . I believe we need to update the same in the sample here, what do you think?

Done

@meggm meggm requested a review from ashleyvjoy May 6, 2025 06:47

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@meggm meggm merged commit 49efea0 into main May 6, 2025
6 checks passed
@meggm meggm deleted the usr/meggm/metro_host branch May 6, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants