Cleaning up controller tests#463
Merged
Merged
Conversation
- move contoller pkg tests from "controller_test" pkg to "controller" pkg. - requires deletion of mocks that were not in use because it caused an import cycle. mocks were generated and can be generated again if needed
santhoshatdell
approved these changes
Apr 11, 2025
santhoshatdell
left a comment
Contributor
There was a problem hiding this comment.
GitHub issue is missing.
Contributor
Author
added! |
falfaroc
approved these changes
Apr 14, 2025
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving controller tests to the from the
controller_testpkg to thecontrollerpkg to facilitate test having access to the struct members and functions they're testing without requiring everything from controller be exported.In doing so, two unused, auto-generated mocks files were removed because they are imported by the controller pkg tests and, in turn, the two files would import the csi-powerstore controller pkg, creating an import loop.
I confirmed they were unused, the tests still run and pass, and the mocks package is not imported by any other repos: source
controllerfrom the tests, as they are no longer needed since they are now part of the same package.Additionally, making small improvements to organization in the Makefile, and fixing one unit tests in node_test.go that fails when run locally.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksHow Has This Been Tested?
Executed unit tests locally and via GH actions.