Skip to content

fix: Removing SysBlockDir from gofsutil FS object#451

Merged
satyakonduri merged 1 commit into
mainfrom
removing-SysBlockDir
Mar 25, 2025
Merged

fix: Removing SysBlockDir from gofsutil FS object#451
satyakonduri merged 1 commit into
mainfrom
removing-SysBlockDir

Conversation

@samihan-dell

@samihan-dell samihan-dell commented Mar 25, 2025 •
edited by satyakonduri
Loading

Copy link
Copy Markdown
Contributor

Description

Removed SysBlockDir from gofsutil FS object

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed the driver with these changes and successfully executed the cert-csi test suite.

  • [ ]
    image

  • Test B

@samihan-dell samihan-dell self-assigned this Mar 25, 2025
@github-actions

github-actions Bot commented Mar 25, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerstore/cmd/csi-powerstore 0.00% (ø)
github.com/dell/csi-powerstore/pkg/array 0.00% (ø)
github.com/dell/csi-powerstore/pkg/common/fs 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerstore/cmd/csi-powerstore/main.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerstore/pkg/array/array_test.go
  • github.com/dell/csi-powerstore/pkg/common/fs/fs_test.go

@samihan-dell samihan-dell marked this pull request as ready for review March 25, 2025 10:07
@satyakonduri satyakonduri merged commit 45df1a8 into main Mar 25, 2025
@satyakonduri satyakonduri deleted the removing-SysBlockDir branch March 25, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@suryagupta4 suryagupta4 suryagupta4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samihan-dell samihan-dell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samihan-dell @AkshaySainiDell @suryagupta4 @satyakonduri