Skip to content

Dqa image version update#430

Merged
donatwork merged 7 commits into
mainfrom
dqa-image-version-update
Feb 6, 2025
Merged

Dqa image version update#430
donatwork merged 7 commits into
mainfrom
dqa-image-version-update

Conversation

@gilltaran

@gilltaran gilltaran commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Description

Changes for Image version update release action

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1490

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

image_version_update1
image_version_update2
image_version_update3

@gilltaran gilltaran marked this pull request as ready for review February 3, 2025 10:55
image-version-update:
uses: dell/common-github-actions/.github/workflows/image-version-workflow.yaml@main
with:
version: "${{ github.event.inputs.version || 'minor' }}"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, one can provide a full version or just the minor one?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the inputs would only be major, minor, or patch. If one isn't provided, the default is minor version

@donatwork donatwork merged commit 6e80117 into main Feb 6, 2025
@donatwork donatwork deleted the dqa-image-version-update branch February 6, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants