Skip to content

Fix build: Move evaluation to recipe block#418

Merged
AkshaySainiDell merged 1 commit into
mainfrom
fix-build
Jan 27, 2025
Merged

Fix build: Move evaluation to recipe block#418
AkshaySainiDell merged 1 commit into
mainfrom
fix-build

Conversation

@donatwork

Copy link
Copy Markdown
Contributor

Description

The eval of the csm-common.mk has to be in the recipe block. This has been overlooked as in may cases the previous csm-common.mk is left over. In some versions of make the eval is executed first, even before the curl command. We have to eval the csm-common.mk variables when the recipe is executed and after the curl command is run.

Change is to move the eval to the beginning of the recipes.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built image with changes in clean repo. Verified that image built.

@donatwork

Copy link
Copy Markdown
Contributor Author

Please merge as soon as the needed approvals are met. Thanks.

@AkshaySainiDell AkshaySainiDell merged commit 4edb2e4 into main Jan 27, 2025
@AkshaySainiDell AkshaySainiDell deleted the fix-build branch January 27, 2025 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants