Skip to content

Fix mountOptions not applied during node stage and expand volume#375

Merged
suryagupta4 merged 8 commits into
mainfrom
bugfix-1582-mountoptions
Nov 12, 2024
Merged

Fix mountOptions not applied during node stage and expand volume#375
suryagupta4 merged 8 commits into
mainfrom
bugfix-1582-mountoptions

Conversation

@AkshaySainiDell

@AkshaySainiDell AkshaySainiDell commented Nov 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Apply mountOptions during node stage volume and node expand volume

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1582

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver and then created SC, PVC and POD that uses mount options (nfsvers=4.1)

@AkshaySainiDell AkshaySainiDell marked this pull request as ready for review November 12, 2024 10:37
@adarsh-dell

adarsh-dell commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Hi @AkshaySainiDell , Can you please add a screenshot of UT coverage?
Thanks

@AkshaySainiDell

AkshaySainiDell commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

Hi @AkshaySainiDell , Can you please add a screenshot of UT coverage? Thanks

UT results https://github.com/dell/csi-powerstore/actions/runs/11795706312/job/32855987013?pr=375
image

@suryagupta4 suryagupta4 merged commit 7231aff into main Nov 12, 2024
@suryagupta4 suryagupta4 deleted the bugfix-1582-mountoptions branch November 12, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi16394 abhi16394 Awaiting requested review from abhi16394

@donatwork donatwork Awaiting requested review from donatwork

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

2 more reviewers

@suryagupta4 suryagupta4 suryagupta4 approved these changes

@adarsh-dell adarsh-dell adarsh-dell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkshaySainiDell @adarsh-dell @suryagupta4