Skip to content

Update Dell client and modules#368

Merged
donatwork merged 5 commits into
mainfrom
csm112-modules-update
Oct 29, 2024
Merged

Update Dell client and modules#368
donatwork merged 5 commits into
mainfrom
csm112-modules-update

Conversation

@donatwork

@donatwork donatwork commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

Description

Update of the Go client and modules.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Installed test image built with the updated modules. Ran cert-csi test suites volume-creation and provisioning. Used NVMe protocol to get more NVMe testing. Will do more testing when the Replication module is updated.

Comment thread go.mod Outdated

@santhoshatdell santhoshatdell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test results before merging.

@donatwork donatwork marked this pull request as ready for review October 29, 2024 17:04
@donatwork donatwork merged commit f394323 into main Oct 29, 2024
@donatwork donatwork deleted the csm112-modules-update branch October 29, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants