Revert "Initialize hosts during dynamic secret update"#367
Merged
Conversation
This reverts commit fc8ce02.
santhoshatdell
approved these changes
Oct 25, 2024
donatwork
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit fc8ce02.
Reverting commit because driver was working as expected.
If a new array is added to the host, a restart of the driver pods is required in order to provide node topology information to kubelet via its
NodeGetInfo()request. If hosts are configured after theNodeGetInfo()request is fulfilled, topology information is not updated on the worker nodes and could cause issues when applying topology constraints.Documentation will be updated to clarify when dynamic secret update applies and when the driver should be restarted.
Documentation updates: dell/csm-docs#1330
GitHub Issues
Checklist:
How Has This Been Tested?
Integration testing with cert-csi
iscsi
nvme tcp
metro replication