Skip to content

Revert "Initialize hosts during dynamic secret update"#367

Merged
lukeatdell merged 1 commit into
mainfrom
usr/lukeatdell/revert-dynamic-host-create
Oct 28, 2024
Merged

Revert "Initialize hosts during dynamic secret update"#367
lukeatdell merged 1 commit into
mainfrom
usr/lukeatdell/revert-dynamic-host-create

Conversation

@lukeatdell

@lukeatdell lukeatdell commented Oct 25, 2024

Copy link
Copy Markdown
Contributor

Description

This reverts commit fc8ce02.

Reverting commit because driver was working as expected.
If a new array is added to the host, a restart of the driver pods is required in order to provide node topology information to kubelet via its NodeGetInfo() request. If hosts are configured after the NodeGetInfo() request is fulfilled, topology information is not updated on the worker nodes and could cause issues when applying topology constraints.

Documentation will be updated to clarify when dynamic secret update applies and when the driver should be restarted.
Documentation updates: dell/csm-docs#1330

GitHub Issues

GitHub Issue #
https://github.com/dell/csm/issues/1538

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Integration testing with cert-csi

iscsi

image
image

nvme tcp

image
image

metro replication

image
image

@lukeatdell lukeatdell marked this pull request as ready for review October 28, 2024 20:25
@lukeatdell lukeatdell merged commit d356bb4 into main Oct 28, 2024
@lukeatdell lukeatdell deleted the usr/lukeatdell/revert-dynamic-host-create branch October 28, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants