Skip to content

Error logging for duplicate host nqns#364

Merged
suryagupta4 merged 15 commits into
mainfrom
1530_duplicate_hostnqn
Oct 25, 2024
Merged

Error logging for duplicate host nqns#364
suryagupta4 merged 15 commits into
mainfrom
1530_duplicate_hostnqn

Conversation

@suryagupta4

@suryagupta4 suryagupta4 commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Description

Error logging for duplicate host nqns when found on the kubernetes nodes.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1530

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on OCP cluster where duplicate host nqns were present in case of NVMe protocol. Error logged in that case.

@suryagupta4 suryagupta4 self-assigned this Oct 24, 2024
@suryagupta4 suryagupta4 merged commit 44479cf into main Oct 25, 2024
@suryagupta4 suryagupta4 deleted the 1530_duplicate_hostnqn branch October 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants