Skip to content

Updates for quay.io registry#363

Merged
donatwork merged 6 commits into
mainfrom
1435-quay-repo
Oct 25, 2024
Merged

Updates for quay.io registry#363
donatwork merged 6 commits into
mainfrom
1435-quay-repo

Conversation

@donatwork

Copy link
Copy Markdown
Contributor

Description

  • Use quay.io locations for images referenced on docker.io.
  • Add a flag for pointing to the nightly images in the offline bundler.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1435

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran through the offline creation and prep steps. Manual inspection of modified values.yaml to check that the quay.io locations are referenced only for the CSM images. Other registry location are not modified.
  • Performed offline install of the driver.

* Use quay.io locations for offline installer.
* Add a flag for pointing to the nightly images.
vgsnapshotter: dellemc/csi-volumegroup-snapshotter:v1.4.0
podmon: dellemc/podmon:v1.8.0
metadataretriever: dellemc/csi-metadata-retriever:v1.6.0
replication: quay.io/dell/container-storage-modules/dell-csi-replicator:v1.9.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replicator version will be 1.10. Could you check the same for metadata-retriever?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. The metadata-retriever is at 1.8.0.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw an update to 1.9.0 for the metadata-retriever.

santhoshatdell
santhoshatdell previously approved these changes Oct 24, 2024
@donatwork donatwork requested a review from kumarkgosa October 24, 2024 20:00
@donatwork donatwork merged commit a3e0c25 into main Oct 25, 2024
@donatwork donatwork deleted the 1435-quay-repo branch October 25, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants