Skip to content

Remove unused code related to register k8s cluster#333

Merged
suryagupta4 merged 5 commits into
mainfrom
bug-1317-remove-unused-code
Jun 25, 2024
Merged

Remove unused code related to register k8s cluster#333
suryagupta4 merged 5 commits into
mainfrom
bug-1317-remove-unused-code

Conversation

@suryagupta4

@suryagupta4 suryagupta4 commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Description

Remove unused code related to register k8s cluster

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1317

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • cert-csi
    image

  • make test
    image

@suryagupta4 suryagupta4 self-assigned this Jun 21, 2024

@AkshaySainiDell AkshaySainiDell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adarsh-dell
adarsh-dell previously approved these changes Jun 25, 2024

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adarsh-dell

Copy link
Copy Markdown
Contributor

@suryagupta4 Can you please update the Copyright Years?

@suryagupta4 suryagupta4 merged commit 7a7bba8 into main Jun 25, 2024
@suryagupta4 suryagupta4 deleted the bug-1317-remove-unused-code branch June 25, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants