Skip to content

Return FailedPrecondition if the volume has associated snapshot#330

Merged
shanmydell merged 1 commit into
mainfrom
bug/delSnapVolRetFailPReCond
Jun 19, 2024
Merged

Return FailedPrecondition if the volume has associated snapshot#330
shanmydell merged 1 commit into
mainfrom
bug/delSnapVolRetFailPReCond

Conversation

@delldubey

@delldubey delldubey commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Description

  • Stops deletion of volumes if it has associated snapshots.
  • Return FailedPrecondition if the volume has associated snapshots.
  • Solves the issue of using snapshots when the source PVC has been deleted.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1338

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Cluster Test
  • Unit Test
  • image

@boyamurthy boyamurthy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adarsh-dell adarsh-dell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @delldubey , This LGTM.
I have a small query: Is there any plan to document this behavior in the CSM documentation for future reference?

Thanks,
Adarsh

@shanmydell shanmydell merged commit 8647c43 into main Jun 19, 2024
@shanmydell

Copy link
Copy Markdown
Contributor

@adarsh-dell : Please raise a defect and add this PR so that it gets added to fixed issues in release notes, thanks

@gallacher gallacher deleted the bug/delSnapVolRetFailPReCond branch June 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants