Skip to content

Multi-AZ remote volume update for replication#476

Merged
bharathsreekanth merged 4 commits into
mainfrom
usr/sreekb/replication-support
Sep 5, 2025
Merged

Multi-AZ remote volume update for replication#476
bharathsreekanth merged 4 commits into
mainfrom
usr/sreekb/replication-support

Conversation

@bharathsreekanth

@bharathsreekanth bharathsreekanth commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

Description

Add remote AZ network details in createRemoteVolume so that upon a failover and reprotect, the volume is exposed on the right network interfaces.

GitHub Issues

List the GitHub issues impacted by this PR:

| GitHub Issue # |
https://github.com/dell/csm/issues/1991

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

manually tested on the provided multi-az infra. Source Powerscale where volume was initially provisioned had one access-zone (which in this case was System as there were issues with other AZs). The target volume, had a different AZ and upon failover and reprotect it was verified that the volumes were part of the specified AZ network. The AZ network it was part of was the one specified as part of the RemoteAzNetwork parameter in the storage class.

lukeatdell
lukeatdell previously approved these changes Sep 5, 2025
falfaroc
falfaroc previously approved these changes Sep 5, 2025

@falfaroc falfaroc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the yamllint issues. Aside from that, LGTM 👍🏽

@bharathsreekanth bharathsreekanth dismissed stale reviews from falfaroc and lukeatdell via 11b48c7 September 5, 2025 15:08
@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/replication.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/step_defs_test.go

@bharathsreekanth bharathsreekanth merged commit c030a3f into main Sep 5, 2025
6 checks passed
@bharathsreekanth bharathsreekanth deleted the usr/sreekb/replication-support branch September 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants