Multi-AZ remote volume update for replication#476
Merged
Conversation
9275d64 to
78cddd6
Compare
lukeatdell
previously approved these changes
Sep 5, 2025
falfaroc
previously approved these changes
Sep 5, 2025
falfaroc
left a comment
Collaborator
There was a problem hiding this comment.
Fix the yamllint issues. Aside from that, LGTM 👍🏽
11b48c7
Contributor
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
santhoshatdell
approved these changes
Sep 5, 2025
falfaroc
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add remote AZ network details in createRemoteVolume so that upon a failover and reprotect, the volume is exposed on the right network interfaces.
GitHub Issues
List the GitHub issues impacted by this PR:
| GitHub Issue # |
https://github.com/dell/csm/issues/1991
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
manually tested on the provided multi-az infra. Source Powerscale where volume was initially provisioned had one access-zone (which in this case was System as there were issues with other AZs). The target volume, had a different AZ and upon failover and reprotect it was verified that the volumes were part of the specified AZ network. The AZ network it was part of was the one specified as part of the RemoteAzNetwork parameter in the storage class.