Skip to content

Add Authorization + Replication Support#471

Merged
satyakonduri merged 2 commits into
mainfrom
rep-auth-fix
Sep 2, 2025
Merged

Add Authorization + Replication Support#471
satyakonduri merged 2 commits into
mainfrom
rep-auth-fix

Conversation

@satyakonduri

@satyakonduri satyakonduri commented Aug 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Add Authorization + Replication support

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Backward Compatibility: Expand old volume created with prefix, in without tenant prefix logic env – Done
  • Backward Compatibility: Deletion of old Pod created with prefix, in without tenant prefix logic env – Done
  • Backward Compatibility: New Pod Creation after removing the tenant prefix logic – Done
  • Backward Compatibility: Deletion of old PVC/Volume created with prefix, in without tenant prefix logic env – Done
  • Backward Compatibility: Creation of Volume Snapshot with prefixed pvc, in without tenant prefix logic env – Done
  • Backward Compatibility: Restore Volume Snapshot to a new PVC and create a Pod (data verification successful) without - tenant prefix logic – Done
  • Backward Compatibility: Deletion of Volume Snapshot in without tenant prefix logic env – Done
  • replication E2E tests (with and without authorization enabled). – Done
  • Authorization E2E tests – Done
  • OpenShift (OCP) E2E tests – Done

@satyakonduri satyakonduri force-pushed the rep-auth-fix branch 2 times, most recently from 078c75a to 68b1047 Compare August 29, 2025 07:42
@satyakonduri satyakonduri marked this pull request as ready for review September 1, 2025 10:49
@satyakonduri satyakonduri changed the title WIP: Add Authorization + Replication Support Add Authorization + Replication Support Sep 1, 2025
rajkumar-palani
rajkumar-palani approved these changes Sep 1, 2025
View reviewed changes

@rajkumar-palani rajkumar-palani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Update Auth E2E after successful run.
Update the Relevant Github Issue Id in the description.

@satyakonduri

satyakonduri commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

Auth E2E is successful.

@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/dell/csi-powerscale/service 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/dell/csi-powerscale/service/controller.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/node.go 0.00% (ø) 0 0 0
github.com/dell/csi-powerscale/service/replication.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/dell/csi-powerscale/service/step_defs_test.go

@satyakonduri satyakonduri merged commit 74ddc92 into main Sep 2, 2025
6 checks passed
@satyakonduri satyakonduri deleted the rep-auth-fix branch September 2, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atye atye Awaiting requested review from atye

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@chimanjain chimanjain Awaiting requested review from chimanjain

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL

@meggm meggm Awaiting requested review from meggm

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani

@Sakshi-dell Sakshi-dell Awaiting requested review from Sakshi-dell

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra

1 more reviewer

@khareRajshree khareRajshree khareRajshree approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@satyakonduri @rajkumar-palani @khareRajshree