Increase UT coverage in controller publish volume#454
Merged
OliverChen557 merged 2 commits intoAug 13, 2025
Conversation
hoppea2
approved these changes
Aug 13, 2025
OliverChen557
commented
Aug 13, 2025
|
|
||
| vcs := []*csi.VolumeCapability{req.GetVolumeCapability()} | ||
| vcs := []*csi.VolumeCapability{getVolumeCapabilityFromReq(req)} | ||
| log.Debugf("Volume capabilities: %s", vcs[0].AccessType) |
Contributor
Author
There was a problem hiding this comment.
Debug log will be removed in next PR.
enestvedto-dell
approved these changes
Aug 13, 2025
b63899f
into
usr/oliver/port-multi-tenant-changes
13 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increase UT coverage in controller publish volume to 90%
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration